Shahar Soel
Shahar Soel
- Need to combine unit/integration tests. - Integration tests coverage is not collected.
Should an aggregation without AltTypes: - Raise an issue when used as an attribute? should it be unknown attribute error? - if deprecated raise a deprecated warning when using as...
The `namespace` property returned is a `BaseUI5Node`, Should it be a plain **UI5Namespace** instead? - https://github.com/SAP/ui5-language-assistant/blob/f2d29237e633cf30454f7ecba03fed1e940e999f/packages/logic-utils/api.d.ts#L152-L165 This is due to some possible edge cases that existed or may exist in...
It is currently defined using the **general** "UI5Type" type union. - https://github.com/SAP/ui5-language-assistant/blob/f1096861ec041372a349d7f17d755b0483aad1e6/packages/semantic-model-types/api.d.ts#L106-L111 Relevant Discussion: - https://github.com/SAP/ui5-language-assistant/pull/164#pullrequestreview-428133880 @codeworrior said: > The “type“ property should be restricted to UI5Class | UI5Interface, that’s...
Some of the utilities in the `logic-utils` package are not specific to UI5 flows or structures. These should be part of @xml-tools/common to avoid future duplication / re-implementation. e.g: -...
In most flows it is the `perceived` human performance that counts, so things that take < 100ms are virtually instantaneous. The question if there are some flows that may become...