ui5-language-assistant icon indicating copy to clipboard operation
ui5-language-assistant copied to clipboard

UI5Aggregation.type may be too wide

Open bd82 opened this issue 3 years ago • 0 comments

It is currently defined using the general "UI5Type" type union.

  • https://github.com/SAP/ui5-language-assistant/blob/f1096861ec041372a349d7f17d755b0483aad1e6/packages/semantic-model-types/api.d.ts#L106-L111

Relevant Discussion:

  • https://github.com/SAP/ui5-language-assistant/pull/164#pullrequestreview-428133880

@codeworrior said:

The “type“ property should be restricted to UI5Class | UI5Interface, that’s what the runtime expects The “altTypes” array is not really validated / restricted in the runtime implementation, but it was originally intended to be limited to primitive types and maybe enums (as they are a kind of primitive)

bd82 avatar Jul 28 '20 11:07 bd82