Shahar Soel

Results 187 comments of Shahar Soel

A possible complex macro example would be `OR_BACKTRACK` which would try N subrules in sequence backtracking each time a failure is encountered and perhaps even having a default fallback. (e.g...

I think the generated syntax was incorrect `=` sign should be removed when using interfaces

I don't know why this eslint rule prefers `interface` but I don't think its because of extensibility reasons. Basically TypeScript uses a **Structured type** system as opposed to a **Nominal**...

After inspecting at the ESLint rule, it is not about one being better than the other, simply a question of project wide **style** **consistency** - https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/consistent-type-definitions.md The optimal workaround would...

Closing this PR as this seems like a subjective style question... 😄

> interfaces are extensible in the way that you can redeclare the interface somewhere else and the definitions will be merged. This feature is useful for generated code. 👍 re-opening...

I'll try to review and promote this PR over the coming weekend

I think this should be evaluated at April 2023 once nodejs 16 is deprecated and all LTS nodejs versions will support ESM.

By definition this is a breaking change, however if the creation of TokenTypes is always done by calling createToken, does it matter if the API gets broken? does it really...

I think this structure may actually be missing one of the more important properties (tokenIdx/Idx)