bcronin
bcronin
Is the request that the contents of the `src/` directly _not_ use ES6 JavaScript? Note that source maps are provided with the Babel compiled code produced in the `lib/` directory....
I hear you, esp. with regards to source maps and production code. Thinking aloud, if the library goes this route, we'll need to nail down what version of "vanilla node"...
Closed this a bit prematurely. I do think this is a scenario that needs to be considered. Implementing a single shared tracer instance across different modules may be not-that-obvious. E.g....
(Preface: I don't claim to be an expert of how NPM module inclusions work! I am glad to be corrected here if I'm making wrong assumptions.) Ensuring the OpenTracing instance...
@syrnick , what version of mocha are you using? I certainly believe mocha is complaining about the use of window / global, but I'm (surprisingly) unable to reproduce the error...
@syrnick: I'm still looking for a way to reproduce the mocha error locally. Is this some interaction with your build process or there is a way to recreate the error...
I appreciate the detailed comments! As a mini-preface, to keep things focused on first the problem before the solution, I would very much appreciate being able to establish a test...
My vote would be for "remove them completely and let users use TypeScript if they want (compile-time) type safety."
@DeTeam , admittedly I'm not a TypeScript expert but if it's conventional to host typedefs along with the JS code, I'd be glad to accept the addition!
I may be wrong, but an explicit callback is required in case `setUp` or `tearDown` call any asynchronous code. The call to the callback is the only way the framework...