Bernardo Cotrim

Results 13 comments of Bernardo Cotrim

I would find this useful for my projects. @mgtitimoli are you going to finish this up? otherwise I could pick it up.

> @bcotrim @wojtekn, I'd appreciate a second review of the suggested approach here to confirm whether I should proceed with it or not. I understand that the HOF could make...

> The thought of using an ESLint rule struck me, too. Your screenshot looks promising, @bcotrim. Thinking out loud: if we choose a linter-based approach, the rules should go like...

@nightnei @fredrikekelund This PR should be ready for review. As we discussed I changed this back to a simpler approach without the HOF. I would still recommend reviewing/merging this one...

> On a more birds-eye-view note, I also recommend adding something like this to `cli/index.ts`: > > ```ts > process.on( 'uncaughtExceptionMonitor', async () => { > await unlockAppdata(); > }...

Thanks for the review @nightnei In Fredrik's PR you had some concerns about the readability and usage of the HOF, the ESLint rule allows us to not use that while...

@nightnei @epeicher thanks for reviewing! There was an issue with the rule scope. Can you take another look please?

On ticket: 7902359-zen The user provided browser information: https://www.whatsmybrowser.org/b/JM1UD

Thanks for the review @wojtekn! I've addressed the comments: - Grouped Playground packages at the end of package.json for easier replacement - Removed the rs command reference - Updated revert...

Closing this as it is outdated. I will address this issue as part of STU-873 in another PR