Brian Collamore

Results 31 issues of Brian Collamore

To simplify, detect a ToString() then immediately assigns to a discard (and rely on IntelliSense to detect that it's an unused variable, turning it into a discard). _Originally posted by...

new analyzer

Recently added SonarCloud exposed misc code cleanup recommendations. _Originally posted by @ynsehoornenborg in https://github.com/philips-software/roslyn-analyzers/pull/159#discussion_r1045447362_

Add support for Release Tracking https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md

The following card is not a discard, but a variable named underscore: `byte[] _ = ExtractData(reader); `

good first issue
new analyzer

We could create a `SingleDiagnosticVerifier` class, that only supports the `SingleDiagnosticAnalyzer` and eliminate this check. _Originally posted by @ynsehoornenborg in https://github.com/philips-software/roslyn-analyzers/pull/362#discussion_r1096661214_

ci/cd

PH2101 Dereference Null did not trip on this code: ``` DataGridViewTextBoxCell assignedCell = row.Cells[_colAssignedValue.Index] as DataGridViewTextBoxCell; if (assignedCell.Value == null) { assignedCell.Value = string.Empty; } ``` Once IDE0074 was applied,...

bug

Please create an extended documentation MD file (PH2138.md) _Originally posted by @ynsehoornenborg in https://github.com/philips-software/roslyn-analyzers/pull/430#discussion_r1111024889_ Also: * Finish documentation for "FunctionalProgramming.md" * Confirm category is FunctionalProgramming or Cardinality

documentation

CodeQL runs much slower than the other workflows, temporarily blocking the upload of artifacts. Rather than executing with every PR, run on a regular schedule instead.

ci/cd

to merge_group, per https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#merge_group

ci/cd

Rather than auto-releasing every time on change. Note: we have artifacts for 1 day with every build.

ci/cd