Brian Collamore

Results 14 comments of Brian Collamore

I've likewise been trying to not Clean. Context: I am attempting to use https://github.com/stryker-mutator/stryker-net (which uses buildalyzer) in a dockerized GitHub Action, and I do not want to 'restore' in...

Agreed Dave. This is incorrect. After looking more into it, my problem seems more in line with https://github.com/daveaglick/Buildalyzer/issues/105.

Apologies @rouke-broersma for the delay! I finally made my way back to this investigation. Most (or all?) of the BuildAlyzer replacement logic is in the file MsBuildProjectAnalyzer.cs, with some initialization...

I have been looking at various types of sample projects and have already observed multiple interesting (that is, eye-opening) edge cases. I will document them herein in the next couple...

* Updated ProjectFileReader to use abstraction layer. (Now 1 place where Buildalyzer is directly used.) * Removed AnalyzerOption: (Explicitly only support Buildalyzer.) * Move Logging of AnalyzerResult details into AnalyzerResult...

Understood @rouke-broersma. In the meantime I completed encapsulation of Buildalyzer (i.e., porting ProjectFileReader to use the abstraction layer). There would seem to be benefits of encapsulating Buildalyzer independent of replacing...

See https://github.com/stryker-mutator/stryker-net/pull/1919 for an as-of-yet non-operational proof-of-concept for using MsBuild for analysis. I can try to make it functional after I return from a vacation in a week.

See the aforementioned PR for a now-operational proof-of-concept of how replacing BuildAlyzer can work (or more specifically, how a compile-time or run-time choice could be made to use BuildAlyzer or...

Is Buildalyzer really needed? Would it be too drastic to instead use Roslyn APIs directly?

@rouke-broersma I confess it has been ~18 months since I looked at this specific issue, so I do not recall if we would need the Roslyn APIs (e.g., https://docs.microsoft.com/en-us/dotnet/api/microsoft.codeanalysis.projectinfo?view=roslyn-dotnet-4.0.1) or...