Benjamin E. Coe

Results 351 comments of Benjamin E. Coe

Tests are mostly green over the past month (there's one other failure) and nightly passed. Downgrading to P2.

we're running into this problem too; purging from the Fastly console works like a charm, but the purge command via the authenticated client seems to do nothing.

@defunctzombie this seems like a reasonable expectation 👌

To avoid large files on disk, I can't see why we couldn't introduce a filtering option (I think we could do so as we write the coverage output to disk...

Is this worth keeping open @isaacs? I'd love to avoid userland implementations over coverage needing to open an inspector session, which motivated NODE_V8_COVERAGE.

Note: our renovate PRs seem to continue rebasing, making this a larger issue: https://github.com/renovatebot/renovate/issues/17762

defer to @danielbankhead's review.

Needs integration tests yet, this is a smoke test.