Benjamin E. Coe

Results 361 comments of Benjamin E. Coe

@jcbjoe please feel free to send an email to `bencoe [at] google.com`. If the errors are within SLA, I can't promise I can do much. But I am, at least,...

@JustinBeckwith I think having it as an optional dependency would be a heavy-handed for our non-TypeScirpt users, as I believe this will attempt an install of the dep (_and just...

If possible, I would love for us to land [this bug fix for rimraf](https://github.com/nodejs/node/pull/35566) too, which we found while working on the `rm()` feature. It seems to address the known...

@jmeas @hzoo let me know if you run into any issues, happy to land patches 👍 @hzoo also, reminds me, I owe you adding `babel-plugin-istanbul` to babel's own tests!

@revin @Announcement would you be open to pulling in `yargs` for this? it gives nice pretty output, and will scale better as we add more configuration options.

yarrrrgs \o/ If you decide to add some tests for the CLI behavior, here's the approach we use in the yargs codebase itself: https://github.com/bcoe/yargs/blob/master/test/integration.js we use this along with: https://github.com/bcoe/nyc...

@revin 👋 I haven't had a chance to dig into this yet, but I'd be interested to see if we can replace the regex with `//g` and avoid the recursive...

as an alternative, if we can't, we could switch the recursive step to a stack structure and at least eliminate the chance of a stack overflow.

@revin did you come to any decision on this issue? I'm almost tempted to keep our exiting behavior until it collides with future work we're doing, then we can take...

@daphee if I understand correctly, this will switch from Youtube being enabled by default to be enabled when a flag is set?