mavis icon indicating copy to clipboard operation
mavis copied to clipboard

Unused variables in validation module

Open zhemingfan opened this issue 1 year ago • 2 comments

Certain parts of the validate module contains redundant code: For example - count: https://github.com/bcgsc/mavis/blob/develop_v3/src/mavis/validate/align.py#L417

Align_options for BWA-MEM, which doesn't use any additional align parameter. https://github.com/bcgsc/mavis/blob/develop_v3/src/mavis/validate/align.py#L464

These should be removed or better documented.

zhemingfan avatar Aug 15 '22 20:08 zhemingfan

Hi @zhemingfan,

Just to clarify, did you encounter an error here or is this something you noticed could be be improved upon?

mattdoug604 avatar Oct 25 '22 15:10 mattdoug604

For now, it's just enhancements.

zhemingfan avatar Oct 25 '22 18:10 zhemingfan