btl_bloomfilter icon indicating copy to clipboard operation
btl_bloomfilter copied to clipboard
verified publisher icon bcgsc

Clang tidy

Open jwcodee opened this issue 6 years ago • 6 comments

The error from CI is only from clang-tidy.

jwcodee avatar Jun 29 '19 00:06 jwcodee

clang-tidy should ignore the fileTests/Unit/catch.hpp because it's vendored. You could move it to a subdirectory of vendor/.

sjackman avatar Jul 02 '19 16:07 sjackman

This PR must pass CI before merging. One way to do that is to make the necessary fixes to silence the clang-tidy errors. Another option is to ignore the failure of the clang-tidy errors in the Makefile. The former solution is preferable.

sjackman avatar Jul 02 '19 16:07 sjackman

clang-tidy should ignore the fileTests/Unit/catch.hpp because it's vendored. You could move it to a subdirectory of vendor/.

I'll do this in a separate PR since I'll have to change the regex for the clang-format too. I didn't catch was vendor library too.

jwcodee avatar Jul 02 '19 21:07 jwcodee

Is this PR the next to be merged?

sjackman avatar Jul 19 '19 22:07 sjackman

hmm I don't know how much work it will take to clear all the errors. My original plan was to make the 1.2.0 release then do the clang-tidy work.

jwcodee avatar Jul 19 '19 22:07 jwcodee

That sounds good.

sjackman avatar Jul 19 '19 22:07 sjackman