Bruno Cardoso Lopes

Thanks, this also needs a testcase!

> Thanks for this comment. Just to clarify, I should add the test case to clangir/tree/main/clang/test/CIR/Transforms/merge-cleanups.cir, right? That'd be a good place for it

Any plans to continue the work here?

Gonna close this for now in order to keep tracking of only active PRs, feel free to re-open if there are updated.

Thanks for the detailed explanation @Lancern. @eZWALT another possibility is to mock the relevant constructs out of `#include ` and use them directly into your testcase, so you don't need...

This is great! Thanks @eZWALT and @fabianmcg for driving this, looking forward to patch review!

I cannot find your comment anymore, but this boils down to work that needs to be done, `CIRGenerator.cpp:164!`: ``` // For OpenMP emit declare reduction functions, if required. if (astCtx->getLangOpts().OpenMP)...

Sorry, ended up missing this. A good starting PR would be: 1. Create a new attribute, let's say, `#cir.address_point` or something similar. 2. Change `VTableAddrPointOp` definition in `CIROps.td` to use...

Hi! These functions don't exist, their names refer to snippets of code in traditional CodeGen that needs to be implemented in ClangIR as part of LoweringPrepare.

Sure, starting by the easier ones is the way to go. Please work on them incrementally, one PR each! > above snippets there eg : shouldCreateMemCpyFromGlobal(maybe named differently ?) That...