Bruno Cardoso Lopes
Bruno Cardoso Lopes
@orbiri-ns np, I leave this to you (unless someone grabs it first, perhaps unlikely tho)
@Kritoooo thanks for following up with this! My workflow suggestion: - Do one operation at a time. - Start with the easier ones. - Start with ones we already handle...
You probably need to add `-cir-merge-cleanups` to `cir-opt` invocation?
Nathan just did a rebase, can you please update? Sorry for the churn
Thanks for the detailed explanation (very clarifying) and for thinking about code duplication! > If we follow the skeleton, the code in CIRGenExprScalar.cpp and CIRGenExprComplex.cpp (which hasn't been invented) would...
@Lancern sorry, I was out on vacation. Let me know when you address all reviews and update the PR.
Let me know once this is ready for review again!
@lanza rebased over the weekend, sorry for the churn. Can you rebase this PR again?
> This looks nice. I'll add this in another PR once this PR lands! Sounds good!
Pending replies to the questions asked.