Brian J. Cardiff comments

Results 217 comments of


                                            Brian J. Cardiff

Let `cabal init` remember chosen language within current session

On top of whether the approach of adding the notion of `Session m` make sense, I would have liked to add some tests. But unit tests run with `PurePrompt` which...

Let `cabal init` remember chosen language within current session

But If we use `ReaderT IO` holding an `IORef` in order to write unit test we would also need to loose the current `PurePrompt` I think. Probably I'm missing something...

Let `cabal init` remember chosen language within current session

In order to add tests I think I would need to change the PurePrompt have not only a `[String]` as state but also the session information (ie: `lastChosenLanguage :: Maybe...

Let `cabal init` remember chosen language within current session

I implemented a solution with ReaderT IORef and was able to add test for PurePrompt. Adding a ReaderT pushed for the introduction of a PromptIO which is now the instance...

Let `cabal init` remember chosen language within current session

I'm not sure if the release march is still going or if it ended with the release of 3.12.1.0 (the release information in github does not match the one in...

Let `cabal init` remember chosen language within current session

I squashed and rebased the whole PR in the first commit and then addressed all the feedback in separate commits. Let's see how CI feels 🤞 .

Let `cabal init` remember chosen language within current session

Oops. I just pushed some more cleanups. I can take them back if needed. But I noticed some things that can be improved and send the last two commits. Thanks...

[RFC] Out of the box JSON/YAML serialization

1. Regarding a constructor hack, maybe a better way to go is to allow a different way of declaring constructors that are not checked by the compiler and that is...

`DB::Serializable` deserialization breaks at compile time if a property type includes a `DB` type

I'm surprised this didn't came up before. The following snippet using JSON::Serializable also suffers from this ```crystal require "json" struct Builder include JSON::Serializable @a : Int32? end class A include...

`DB::Serializable` deserialization breaks at compile time if a property type includes a `DB` type

That would be the dual, a type name written in a macro expands at call site and suddenly it binds to something declared in the call site. In this situation...