Bartosz Jarzyna comments

Results 38 comments of


                                            Bartosz Jarzyna

Single pp OP for "if(ref($self) eq 'REFTYPE')" ?

This would be great to have. Ref::Util can optimize this, but would be nice if core could do this without that dependency. `reftype` from builtin should be included in the...

Refactor Perl_av_fetch, optimize path for non-negative key access

I'm sorry, should've checked git blame to see the origin of this code. Porting bench script showed up to 7.5% less data writes and up to 6% less instructions used...

Refactor Perl_av_fetch, optimize path for non-negative key access

@iabyn After thinking this through, I agree. Stable performance is good. I changed the code to do things differently: - added some comments, especially the comment which marks early key...

Refactor Perl_av_fetch, optimize path for non-negative key access

Changed the commit message, should be more descriptive now. (for some reason PR got closed when I force pushed, supposedly on its own - reopened)

Avoid using $_ when loading the commands from namespaces

Bump, why isn't this merged? Seems like a low-hanging fruit.

Avoid using $_ when loading the commands from namespaces

I'm confused. Am I required to take any action here? Did the tests fail? They look like they never ran at all.

Avoid using $_ when loading the commands from namespaces

I rebased to latest main. Seems like workflows await approval now. Maybe that'll fix them.

Avoid using $_ when loading the commands from namespaces

Most tests passed now. Windows test seems to be failing in other PRs too, regardless of their content.