mojo icon indicating copy to clipboard operation
mojo copied to clipboard

Avoid using $_ when loading the commands from namespaces

Open bbrtj opened this issue 1 year ago • 6 comments

Summary

Solution proposed in #2175

Motivation

Polluting $_ can happen deep down in dependencies tree of the loaded command.

References

resolves #2175

bbrtj avatar May 17 '24 18:05 bbrtj

Bump, why isn't this merged? Seems like a low-hanging fruit.

bbrtj avatar Dec 09 '25 07:12 bbrtj

Nobody will even look at it before tests passed,

kraih avatar Dec 09 '25 10:12 kraih

I'm confused. Am I required to take any action here? Did the tests fail? They look like they never ran at all.

bbrtj avatar Dec 09 '25 11:12 bbrtj

No idea what went wrong i'm afraid, and nothing we can do about it.

kraih avatar Dec 09 '25 16:12 kraih

I rebased to latest main. Seems like workflows await approval now. Maybe that'll fix them.

bbrtj avatar Dec 09 '25 17:12 bbrtj

Most tests passed now. Windows test seems to be failing in other PRs too, regardless of their content.

bbrtj avatar Dec 10 '25 03:12 bbrtj