Ben Browning

Consider formatting code with `gofmt`

5

Many Golang project use `gofmt` to consistently format their Go code. And, it's not uncommon to setup your editor to automatically run `gofmt` when saving changes to a file. Perhaps...

Knative Service invocation should use status.url instead of Istio IP

3

Knative Services should be invoked via the Service's `status.url` property instead of setting a host header and directly trying to hit the Istio ingress gateway. Not all Knative installations use...

### Your current environment Running inside an OpenShift cluster, but not directly relevant for the issue in question. ### 🐛 Describe the bug At https://github.com/vllm-project/vllm/blob/2d7bce9cd5981db146b18a8a95c5a7e0480687bd/vllm/model_executor/model_loader/tensorizer.py#L74-L80 the tensorizer loader checks if...

Worker volume name hardcoded and may be wrong in crc_libvirt.sh

5

On line 116 and the 2nd argument on line 118 of https://github.com/praveenkumar/osp4/blob/6f7d3ea9bf2ac194aceac4b3ae1be81d509c6615/libvirt/crc_libvirt.sh#L116 you see the actual on-disk filename of the worker volume is hardcoded. However, when building, the last part...

Don't assume default storage pool is at /var/lib/libvirt/images in crc_libvirt.sh and test1-worker-0-98nsr.xml

1

This script checks that the default storage pool exists and if it doesn't, it creates it at /var/lib/libvirt/images. However, later on in the script, it assumes that the default pool...