Björn Brala

Results 141 comments of Björn Brala

Since the pattern of the BC fixes in rector is pretty much done. Perhaps it is time to see if you can support that. Otherwise the Rector rule will need...

I feel like the the deprecated scope thingies should be able to do this. But only if the referred arguments on the deprecatedhelper class are anonimous functions. I understand that...

@firecow perhaps with a rough description of what needs to be done this could be implemented by someone else :) Would you be be able to give a rough outline...

I've been looking into how i could use two traits, but the ways to do it are very very very very ugly. The sad thing is, the method could have...

Ok, something like this should work. ``` /** * @description In order to support Drupal versions before 10.2 we need to alias the EntityReferenceFieldCreationTrait to EntityReferenceTestTrait. */ if (!class_exists(\Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait::class)) {...

Haha yeah I understand the code will work. But mostly if I can get rector to do it :) But I'll have a look, and perhaps we shouldn't care too...

All code that will be for 10.x deprecation will have that anyways, since deprecationhelper is only available since then.

This can be closed imo. Windows support is not something that's really relevant in my eyes