Bertrand Berthelot

Results 44 comments of Bertrand Berthelot

I have the same issue, but this is not due to webpack. If you are on Windows, see PR #6

I would suggest to use the regular expression /[\r\n]+/g to detect end of lines: `const sourceByLine = source.split(/[\r\n]+/g)`

Additional comment: AbandonRequestRule is considering and counting the download progress steps only if buffer level is lower than stable buffer size (12sec by default). It may be better to count...

I have a concern with the modification that has been made in the TimelineSegmentGetter. Consider the following use case: - play a live stream, with SegmentTimeline and manifest updates -...

Have you tried this?: `import * as dashjs from 'dashjs'`

@technogeek00 can you please check this PR on your side regarding all the changes from your PR #3451? Can you check if does not break anything? Also can you check...

@technogeek00 Did you have time to check this PR and unit tests?

> First I apologize for the delay in my review, but hopefully this is insightful feedback. Thanks a lot for this review. > > I pulled this branch and attempted...

@technogeek00 Have you seen my answers to your reviews ans my last comment?

@technogeek00 in order to progress effectively, do you have any test streams that highlights the issues with current implementation in this PR?