Bozhidar Batsov

Results 1761 comments of Bozhidar Batsov

> This approach respects that by placing the weight of config file values quite high up, between 1) and 2), rather than between 3 and 4, which I originally imagined....

I didn't want to the configuration to get coupled with the server code, that's why it doesn't have any direct integration points with it. The assumption was that each tool...

I was planning to respond to your previous comment, but I totally forgot about this. Will think more on the subject when I'm back from my summer vacation.

Hey there! That'd be great to have, but the problem is that I can't provide you much guidance as I'm not super familiar with the codebase myself (I did very...

I was thinking that we can provide some `:initial-ns` config option in `nrepl.edn`, which should be pretty straight-forward. If we want clients to be able to set the initial-ns, it...

> Thinking about what the client-side change would need to be. Now the only optional param for `clone` is the session id to clone, afterwards you'd also be able to...

I'll add a bit of feedback inline and I'll invite @nrepl/nrepl members to share their opinions as well.

On a general note - won't it be better to handle authorization with some built-in middleware? Seems to me that'd be more in line with the spirit of how we've...

> With respect to middleware -- assuming I understand your comments correctly, I treated the authentication independently under the supposition that authentication is somewhat different. i.e. it's something that should...

> so that it was really clear that authentication happens before anything else, and you can't side-step it. I see. > And with respect to your other suggestions, I have...