Bozhidar Batsov
Bozhidar Batsov
Hmm, do we even need to iterate the derived modes if there's no special smartparens configuration for them? Seems excessive to me. Perhaps the legacy config is from the days...
> I'm currently using this pattern to remove a default Include pattern so it resorts back to the AllCops inclusion list, so setting it to [] does not accomplish the...
@juanxo Ping :-)
@juanxo Ping again :-)
@juanxo Ping again :-)
Sorry for the slow turnaround here - I'm fine with the general direction, but I'll need some time before I can take a closer look at the code, as I've...
It'd also be nice to benchmark the impact of using `require_gem` on several cops, as speed is something quite important for a tool like RuboCop.
> Benchmark this for perf regression – I'm not sure what the best way to do this is. Let me know if you have any suggestions You can simply test...
If @koic doesn't share any feedback I'll merge this after the next bug-fix release.
I don't mind using `Bundler::LockfileParser`. @amomchilov Let us know when you feel the PR is ready for review.