smartparens icon indicating copy to clipboard operation
smartparens copied to clipboard

Published 20 hours ago • verified publisher icon Fuco1

Add support for clojure-ts-mode

Open kommen opened this issue 5 months ago • 5 comments

clojure-ts-mode is developed as a distinct alternative to clojure-mode, as discussed here: https://github.com/clojure-emacs/clojure-mode/issues/640#issuecomment-1359708131

kommen avatar Feb 04 '24 15:02 kommen

Marking as draft until this is resolved: https://github.com/clojure-emacs/clojure-ts-mode/pull/36

kommen avatar Feb 13 '24 07:02 kommen

Hmm, do we even need to iterate the derived modes if there's no special smartparens configuration for them? Seems excessive to me. Perhaps the legacy config is from the days before all modes were folded in clojure-mode?

bbatsov avatar Feb 13 '24 07:02 bbatsov

@bbatsov thanks for the feedback. I can give it a try in the next days without all the derived modes.

kommen avatar Feb 13 '24 13:02 kommen

I removed all the derived modes. As far as I can tell, everything works fine in buffers using the derived modes.

kommen avatar Feb 13 '24 21:02 kommen

@Fuco1 I have reverted the commit which removed the modes from the lists. Would you prefer me to force push it out?

kommen avatar Apr 21 '24 19:04 kommen