rules_foreign_cc

rules_foreign_cc copied to clipboard

make install fails when --prefix needs to be an absolute path

6

I am trying to build nginx from sources. With nginx, it is fairly standard to set `--prefix` to an absolute path. For example, the default value is `/usr/local/nginx`. http://nginx.org/en/docs/configure.html If...

aptenodytes-forsteri

Link only one of the output libs?

3

Hi, I've searched and tried a bit but seems this is a relatively new topic. I have several external projects (configure_make, cmake), each has multiple output libs (i.e. I specify...

wudisheng

ctx.attr.tools_deps and ctx.attr.additional_tools is redundant - rename to a single ctx.attr.tools?

10

There is no real distinction between `ctx.attr.tools_deps` and `ctx.attr.additional_tools`. Most other rules canonically use `ctx.attr.tools` so I am proposing that we should deprecate the former two and move to the...

jsharpe

The tools_deps targets don't include runfiles

2

Where a tools_deps is a build target that includes runfiles the run files are not made available for the tool to use and so the tool fails to run.

jsharpe

Disable cc toolchain resolution in examples on Mac

2

The examples/cmake_android picks up local instead of Android Cc toolchains.

comius

Should be able to filter copts and linkerflags for make, configure_make etc.

3

Currently it appears that foreign_cc is getting compiler and linker flags from the toolchain. While this may be preferable in some circumstances, it will not always work. For example, a...

aaron-michaux

BUILD_TMPDIR and EXT_BUILD_DEPS are deleted before and after running the build command, which means that rebuilds of the external project need to build every single file, which can be expensive...

jbauman42

Specify path to sed on MacOS and FreeBSD

1

The given commands are not portable between BSD sed and GNU sed. Some users (at least me) have their PATH such that `sed` resolves to a sed that is not...

garymm

Issues with transitive includes

3

I am trying to build and use https://github.com/microsoft/LightGBM `WORKSPACE`: ```python3 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_foreign_cc", sha256 = "2a4d07cd64b0719b39a7c12218a3e507672b82a97b98c6a89d38565894cf7c51", strip_prefix = "rules_foreign_cc-0.9.0", url = "https://github.com/bazelbuild/rules_foreign_cc/archive/refs/tags/0.9.0.tar.gz", ) load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies") # This...

baryluk

Expand variables in `configure_options`

1

For cross compiling ffmpeg, I needed to supply the compiler as an argument to `configure`. That is why I needed to add variable expansion to `configure_options` of `configure_make` rule. ```...

petoknm