rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard

Expand variables in `configure_options`

Open petoknm opened this issue 2 years ago • 1 comments

For cross compiling ffmpeg, I needed to supply the compiler as an argument to configure. That is why I needed to add variable expansion to configure_options of configure_make rule.

configure_make(
  ...
  configure_options = [
    ...
    "--cc=$(CC)",
  ]
)

petoknm avatar Aug 29 '22 13:08 petoknm

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 29 '22 13:08 google-cla[bot]

Fixed in https://github.com/bazelbuild/rules_foreign_cc/pull/1102

jsharpe avatar Oct 14 '23 15:10 jsharpe