Sebastian Gräßl

Results 11 comments of Sebastian Gräßl

So, basically the solution is gonna be, if a 'unset!' for a keystroke in a scope exists, mark the matching keybindings as "unset". Maybe grey it out and add an...

Hm. maybe not an info icon, but the "circle-slash" octicon to show it's disabled and possibly use it to toggle the keymap-setting.

In config-schema `invisibles` mentions now that these can be set to `false` to not show them, but this is not shown in the settings view. It would make sense to...

This may have been fixed meanwhile. It appears not to happen anymore, at least in Firefox (119) and Safari (17.1): https://github.com/denoland/fresh/assets/7757/0b8ee070-133a-43b7-bfd5-e42f5a793293

I did also try to manually go to the link, without using the internal link, and enter it manually into the address bar, which also properly preserved the scroll position...

The test added for the `HOST` env var currently covers just the env var, is there a place (already) where the the flags and/or the `dev()` options should be tested?...

Just checking up on here. If this should have more tests, it might be a better path to first add general tests for the `dev` command, which might be better...

@marvinhagemeister After playing with this more, I felt it would be better if flags or environment variables would override what is passed in the options.

ping. Let me know if this PR needs more work. :)

@deer Thank you for taking a look again! The updated docs should now be under canary.