Tim Meusel

Results 521 comments of Tim Meusel
trafficstars

> If there were tests attached to this PR for windows platform, then obviously we wouldn't have to argue about it. the facts module itself has tests for it: https://github.com/puppetlabs/puppetlabs-facts/blob/main/spec/acceptance/windows_spec.rb...

I raised support ticket #01302642 for this

The Arch Linux failure was an actual bug. the puppet package didn't depend on ruby-augeas. I fixed the package upstream.

@C24-AK thanks for the PR! Can you take a look at the rubocop annotations and rebase against the latest main branch (not a merge commit)?

@C24-AK thanks for the patch! Is there a chance for you to add a test for this change?

@C24-AK can you please rebase against main to get rid of the merge commit?

@C24-AK any chance you can add a test for this?

@maxadamo when you rebase against master the failing beaker jobs should turn green/disapper

CI fails because the ruby code isn't valid anymore, please have a look.

Hi, thanks for the Ticket, we're able to reproduce it in https://github.com/puppetlabs/puppetlabs-postgresql/pull/1547