Tim Meusel

Results 515 comments of Tim Meusel
trafficstars

https://github.com/puppetlabs/puppetlabs-java/pull/569

Hey @vStone, the PR looks pretty good! I just made some little inline comments.

hey @gittygoo . Is this change still requried? if so, could you please rebase against our latest master?

> I do not think we should encourage the use of empty data sets like `''`, `[]` and `{}` and should instead use `undef`. From our [review guidelines](https://voxpupuli.org/docs/#reviewing-a-module-pr): > Are...

Hi @idrissneumann, thanks for the work. Please don't delete the tests, they need to be restored and restructured so they work with the defined resources.

Hi, would you be willing to provide a PR with the changes?

@fraenki thanks for the PR, can you please ass FreeBSD to the metadata.json?

A lot of changes going on here and I'm not a redis expert. @ekohl you maybe?

I Also want to point out that Puppet 3 is end of life since 4? years. The latest version is Puppet 7 and Puppet 8 will probably be released in...

Hi @raja5674 , it's not that simple. Before upgrading your puppet agent you should review your code and ensure if it's still compatible with new puppet versions and new module...