puppet-snmp
puppet-snmp copied to clipboard
voxpupuli
Debian(-ish) split sysconfig and systemd support
Remove support for systems that still use one sysconfig file for both daemons. Systemd support for debian systems. Tests cleanup / reorder. Reorder parameters
Hey @vStone, the PR looks pretty good! I just made some little inline comments.
Looks like I'll have to refactor the daemon options too. systemd does not like snmp*d without the -f flag
@bastelfreak since the parameter (and alignments) were a horrible mess (imho), i reordered/re-aligned the lot of them. Made it into a separate commit so the other diffs are not too big
@vStone personally I'm in favor of dropping alignments. Without data types they were annoying but with data types they do more harm than good IMHO.
@vStone personally I'm in favor of dropping alignments. Without data types they were annoying but with data types they do more harm than good IMHO.
Could we postpone further changes to the alignment of the parameters to a separate pull request? :) I already feel bad for including this big alignment change in this one
Could we postpone further changes to the alignment of the parameters to a separate pull request? :) I already feel bad for including this big alignment change in this one
IMHO yes since I don't care about alignment so don't put too much effort into it :)
Its getting worse. Ubuntu requires the pid to be in fixed value with its mixed init/systemd scripts wheep
@bastelfreak @ekohl @Dan33l: I finally got this working on all debian/ubuntu flavors. I created some acceptance tests too because it was a horrible nightmare to figure out how sh*t works on each os. Please re-review ;)
I removed the acceptance test things and I'll make a pr for them later on. Need to figure out the beaker hostgenerator part :) other remarks should be fixed.
Dear @vStone, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
![vox-pupuli-tasks[bot] avatar](https://avatars.githubusercontent.com/in/37588?v=4 "Published by a pub.dev verified publisher"){kind=small}
Dear @vStone, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @vStone, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @vStone, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @vStone, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks