Simone Basso

Results 283 comments of Simone Basso

@arky would you mind reporting these issues in https://github.com/ooni/probe/issues/2661? I am trying to consolidate all these alike cases into a single issue for ease of project management and planning. Thank...

We [can measure the website now](https://explorer.ooni.org/m/20240125174137.408120_IT_webconnectivity_c171e6e03d93d63a) using Web Connectivity v0.5.

I think we're done here. I've also opened https://github.com/citizenlab/test-lists/pull/1623 to update the test lists.

The problem is still current; see this Web Connectivity v0.5 measurement: https://explorer.ooni.org/m/20240125180856.931317_IT_webconnectivity_9ac2252d15d4dd97.

@minhducsun2002 I suggest taking a look at the API documentation and then asking here or on Slack if you require further clarifications

I tested this code for ~30 minutes and it eventually crashed like this: ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x18...

We saw this `-race` error: ``` ================== WARNING: DATA RACE Write at 0x00c00002c190 by main goroutine: runtime.closechan() /usr/local/opt/go/libexec/src/runtime/chan.go:356 +0x0 github.com/ooni/probe-cli/v3/internal/engine.(*asyncSaver).Stop() /Users/art/code/ooni/probe-cli/internal/engine/saver.go:96 +0x64 github.com/ooni/probe-cli/v3/internal/engine.(*InputProcessor).run() /Users/art/code/ooni/probe-cli/internal/engine/inputprocessor.go:101 +0x3fb github.com/ooni/probe-cli/v3/internal/engine.(*InputProcessor).Run() /Users/art/code/ooni/probe-cli/internal/engine/inputprocessor.go:71 +0x44 github.com/ooni/probe-cli/v3/internal/oonirun.(*Experiment).Run() /Users/art/code/ooni/probe-cli/internal/oonirun/experiment.go:115...

🥳 I will take a look! Thank you!

This issue was wrong. When blocking and accessible are None, the probe does not know. This is different from failed. The pipeline should prioritize the fingerprints over the probe's own...

> Thanks for putting this together, it looks great! Thank you for your review! I ended up taking just the `netxlite` part of the diff, applying changes to improve testing,...