Griffin Bassman issues

Results 16 issues of


                                            Griffin Bassman

fix: clear labels and predictions when finishing examples

fix: don't use no_predict by default in cb_adf_greedy

Ensure ec_is_example_header is being used correctly in search.cc

The ec_is_example_header function exists in the CB, CCB, and COST_SENSTIVE namespaces. This has recently caused a bug (in a different file) because the CB version was being called automatically when...

fix: remove experimental and fix up model version test

fix: update fmt for macos vcpkg

From 9.0.0 to 9.1.0 https://github.com/fmtlib/fmt/commit/a33701196adfad74917046096bf5a2aa0ab0bb50

refactor: add windows to asan ci

refactor: option to turn on sse2 optimization

Option to enable SSE2 optimization

1.f / std::sqrt(x) has become the default for inverse square root in gd. Tracking issue to add flag to enable sse2 optimization here: #4666 Min repro: #include #include #include #include...

Feature Request

Slates Json parser error

### Describe the bug Check test 216 stderr: https://github.com/VowpalWabbit/vowpal_wabbit/blob/master/test/core.vwtest.json#L2793 Ran into issue using RLClientLib here: https://github.com/VowpalWabbit/vowpal_wabbit/blob/master/vowpalwabbit/json_parser/src/parse_example_slates_json.cc#L251 ### How to reproduce vw --dsjson --chain_hash --slates -d train-sets/slates_simple_unlabeled.dsjson ### Version 9.9 ###...

Bug

--eval corrupting model state

### Describe the bug `--eval` flag has counterintuitive effects on the model ### How to reproduce This crashes: vw -d train-sets/rcv1_cb_eval --cb 2 --eval -f model vw -i model This...

Bug