Bassam Adnan
Bassam Adnan
can I take this up? I want to work with ASAN abit, I remember encountering issues in pgexporter/pgexporter#178 with the memory bit too so maybe I can add a cmake/Sanitizers.cmake...
are there any specific flags you have in mind?
Yes will do! Is it fine if i do this for pgexporter first? Abit in sync with the codebase there and i can test some of the things i've wanted...
> See src/CMakeLists.txt for the flags we currently have enabled. Just to be sure, we currently do not have any ASan specific flags right? I am thinking about adding these...
Im using [godbolt](https://godbolt.org/). Its the most reliable tool I could find, to test these flags specifically ``` -fsanitize=address -fno-omit-frame-pointer -fsanitize-address-use-after-scope -fsanitize-recover=address -Wall -Wextra ``` These are supported for all clang...
yup, on it!
the gcc test suite does work in abit of a strange manner, both clang and gcc detect leaks in a different way, we currently do not report sanitizer leaks for...
> [@bassamadnan](https://github.com/bassamadnan) Are you available to check this one out? Hi, i suspect it might be due to the way we are closing connections (i.e not closing connections properly) in...
Hi, while I highly appreciate the PR. This version of the `custom_metrics` API was before it was updated to support switching databases (Can be confirmed by going to the history...
tldr; what I had shared earlier (and what has been put into this PR) is an odler version of `custom_metrics`, but I am sure we can localize the issue further...