Basil Goldman

Results 11 comments of Basil Goldman

@rafa8626 , use it as an npm package, I don't see the point in rewriting it to ts, if any additions or changes are needed, let me know. It is...

@rafa8626 , regarding VAST 4.+ it already supports VAST 4.0, you can test your VAST tags in our VAST Inspector/VAST Tester based on this ad manager -> https://adserve.tv/vast-inspector/ VAST 4.0...

@rafa8626 , if you receive warnings about -> 'this' implicitly has type 'any' because it does not have a type annotation. ![Screen Shot 2024-12-11 at 14 05 45](https://github.com/user-attachments/assets/d038cf21-a61a-48b3-801e-4edfe5339b44) disable ->...

@rafa8626, do you have `"strict": true` in your tsconf.json ? if so, comment it out

@rafa8626 , in my free time I will try to generate the definition file -> .d.ts -> https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html

> For your external PubTag code. I think the only other bidder doing something like this is Criteo and they seem to have gotten worked out where you do not...

> Hi @basil79 ; criteo is in process of removing this dependency in prebid 9 Hi @patmmccann , give me their pr I will check

> There is a divide in opinion on whether or not the way you're doing this should be allowed. I've voiced my thoughts on this. I do not feel like...

> They're doing it the intended way, which is to have the external JS in an open source github repo under Prebid. My understanding at least is that this is...