Rob Blanckaert

I happy to accept upstream pull requests.

I've got code working for this, but I'm struggling to come up with a name for the iterator based method. Any suggestions ?

Sorry for the delay getting back to you, it took a bit longer than I thought to get approval from work to share the patch. https://github.com/basicer/immer/commit/0dcde00eaea6e03909eed4c33c81705798181898 I agree the current...

We are considering it! The use case for beginAtOrAfter() is that if the key your looking for is from an old version of the map, you can still iterate. It...


Hey @robertleeplummerjr Checkout skulpty, it has the sort of separation your talking about. It also uses the skulpt parser instead of acorn, so it's a little bit more complete. https://github.com/codecombat/skulpty

The AST filbert uses is pretty similar to the one babel uses, so you might be able to use that very library.

Thanks for the comments! I opened this as a draft as I knew I had a few more passes to go though before it was ready for review. My biggest...

Tested on OSX / Vulkan with the reproduction project posted in #90881 with `LIGHT_VERTEX = (VIEW_MATRIX * vec4(world, 1.f)).xyz;` added to the end of the shader's fragment function.

> > Kind of. Lightmap sampling is mostly driven by `UV2`. But when using lightmaps, the specular reflection takes VERTEX into account and LIGHT_VERTEX will impact that > > That's...