Marc Alvarez comments

Results 6 comments of


                                            Marc Alvarez

Question: Are the decode and encode operations goroutine safe for each encoder or decoder?

👋 Hey @amikai / @makiuchi-d - potentially my change here might be relevant and of interest: https://github.com/makiuchi-d/gozxing/pull/75

fix: clarify refresh token parameter names and improve code readability

Of course! Have found it so helpful to use the lib - appreciate the touchpoint with you. Please do let me know if you run into anything and want to...

fix: clarify refresh token parameter names and improve code readability

No rush @elinashoko - I appreciate the touchpoint. Hope the team is doing well!

fix: consistently handle string-valued boolean fields from non-compliant OIDC providers

@elinashoko - yeah! Been swamped on my end, but should have time by end of this weekend to wrap this up - thanks for being so patient all 🤝

fix: consistently handle string-valued boolean fields from non-compliant OIDC providers

@muhlemmer + @elinashoko - should be all set here, I think the end approach is a nice balance, thanks again! PR feedback implemented, and branch updated accordingly with `main` 🤝...

fix: consistently handle string-valued boolean fields from non-compliant OIDC providers

Thanks @muhlemmer + @elinashoko - totally reasonable change, thanks for the diff, merged and updated! Should be good to go 🤝