Baruch Odem (Rothkoff)

Results 208 comments of Baruch Odem (Rothkoff)

Hi @s-roueche, thanks! I think it means that I have two options. One is to stop supporting V5, and the other one is to maintain two branches. Since V6 is...

Yes, sure! Thank you, I will be happy to see your branch. I also did some local work for the upgrade, and also failed on tests, you can see it...

You should push your fork and open a PR. Use `gh pr create` with the [Github CLI](https://cli.github.com/).

> I wrote my own package to handle state using search params with `react-router-dom-v6`: https://github.com/jschwindt/react-use-search-params-state @jschwindt Why not implement it here?

I will deprecate this package.

> > Are all the syntax changes necessary for this PR? > > It's not necessary 👍 If you can, I will suggest removing formatting changes to easily focus on...

Regarding the tests, I also don't know why they are failing. Is the example website working well? Did you try to use the V6 version in your code? Maybe we...

It is very important to run a test with `--regex` because currently, it working by chance because we're updating a pointer, but if we will lose this pointer, the `--regex`...

Also, validate the ID of the secrets, need to make sure it's not empty and not unexpected duplication.

Some of the secrets (such as Github) are stand-alone tokens, but some of them can be used only by combination (of _Access Token_ and _Secret Token_, such as on _AWS...