use-route-as-state icon indicating copy to clipboard operation
use-route-as-state copied to clipboard

Published 20 hours ago • verified publisher icon baruchiro

react-router-6 migration

Open s-roueche opened this issue 3 years ago • 4 comments

This PR is not finish yet.

4 tests failed.

s-roueche avatar May 04 '22 07:05 s-roueche

Are all the syntax changes necessary for this PR?

itayganor avatar May 06 '22 10:05 itayganor

Are all the syntax changes necessary for this PR?

It's not necessary 👍

s-roueche avatar May 06 '22 16:05 s-roueche

Are all the syntax changes necessary for this PR?

It's not necessary 👍

If you can, I will suggest removing formatting changes to easily focus on what was really changed.

Consider adding ESLint/Prettier in another PR.

baruchiro avatar May 08 '22 06:05 baruchiro

Regarding the tests, I also don't know why they are failing.

Is the example website working well? Did you try to use the V6 version in your code?

Maybe we need to re-write the tests, or skip them for now. What do you think?

baruchiro avatar May 08 '22 06:05 baruchiro