Bartek Iwańczuk

Results 361 comments of Bartek Iwańczuk

@Pangoraw SWC already handles `declare` - https://docs.rs/swc_ecma_ast/0.20.0/swc_ecma_ast/struct.FnDecl.html#structfield.declare Fixing this issue requires to capture nodes that have `declare` keyword, in addition to currently handled `export`.

PR are welcome to upgrade Alpine image.

@kitsonk I think we've discussed this issue recently and came to a conclusion that it's a "won't fix"?

`deno_graph` is used for static analysis of the code, it doesn't have functionality to execute code. If you want to execute modules you need to use `deno_core` crate with [`ModuleLoader`](https://docs.rs/deno_core/latest/deno_core/trait.ModuleLoader.html)

> What I'm trying to do is to essentially import a file which is not typescript or javascript and transpile it on the fly. It seems like that ModuleLoader.load function...

@kitsonk is there anything I can do to help you to land this PR?

@nayeemrmn thanks for suggestion, totally obvious but I missed it. I think this is a lot cleaner.

> You need to rebuild the WASM and ensure whatever impacts on the JS API are handled properly. Rebuilt WASM, it seems JS APIs are not impacted by this change...

@kitsonk do you have any objections to moving arguments of `Builder::build()` into `Builder::new()`? So instead of: ```rust let builder = Builder::new( roots, loader, source_parser, BuilderOptions { is_dynamic_root: options.is_dynamic, maybe_resolver: options.maybe_resolver,...