Bartłomiej Klocek
Bartłomiej Klocek
My review comments are still unaddressed, especially the one about missing `package.json` scripts and missing `app.plugin.js` file.
Hello, I see you have recently opened a few issues with suggestions to docs. If you're feeling familiar with it, we'd love to see a PR from you!
The most cryptic part is that both stacktraces point to lines that are typical [Swift Set](https://developer.apple.com/documentation/swift/set) operations: 1. https://github.com/expo/expo/blob/40c4a73859a5e1676a9a3fd502d25b2a378b521a/packages/expo-keep-awake/ios/KeepAwakeModule.swift#L28 2. https://github.com/expo/expo/blob/40c4a73859a5e1676a9a3fd502d25b2a378b521a/packages/expo-keep-awake/ios/KeepAwakeModule.swift#L31 The `activeTags` is just a normal module property: https://github.com/expo/expo/blob/40c4a73859a5e1676a9a3fd502d25b2a378b521a/packages/expo-keep-awake/ios/KeepAwakeModule.swift#L5-L6...
In SDK 46 beta, Swift modules are loaded differently than in SDK 45 so the crash could be fixed, might be worth trying.
I'm sorry, I didn't express myself clearly - I didn't mean to suggest updating production apps to 46 😅
It's just my blind guess, but these crashes might be caused by some Swift closure stuff. You can try applying these changes using e.g. patch-package: ```diff --- a/node_modules/expo-keep-awake/ios/KeepAwakeModule.swift +++ b/node_modules/expo-keep-awake/ios/KeepAwakeModule.swift...
Ok people. If nobody is able to provide a reliable way to reproduce (I know it might be difficult) or check if the patch I provided fixed the crashes, we...
*Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.* I've found some issues in your pull request that should be addressed (click on...
I don't think it's fixed in SDK 45, unfortunately. We started performing a full audit of the `expo-image-picker`, but we haven't finished it before the latest release due to some...
Ok, I provided a quick patch, _it turned out to be more tricky than I initially thought, due to some weird URI EXIF permissions on Android, left some comments in...