Bartek Szopka
Bartek Szopka
@mas-who Could you also add `p-rule--highlight` on top of the titles, as per design? (https://vanillaframework.io/docs/patterns/rule#highlighted)
One last thing (hopefully) as a drive-by. Currently images have unnecessary spacing below them because they are inline. I think it would be fine to make images block inside `p-media-container`,...
This is relevant to current work, so we should do it in current codebase.
Gov.uk doesn't seem to use anchor links on headings. Headings have ids (so can be linked to), but anchor is only accessible via table of contents, not the heading itself....
> @bartaz The request to have the headings clickable comes from the documentation team Yes, I know. We are just gathering examples of how others are doing something similar.
Hmm… we have the icon of that name, but it's a chevron… I can try to track down if that was a deliberate decision or just some mistake:
We have the icon in code snippet component, it looks like a bug that it got replaced to chevon. We can bring it back.
@petesfrench Create a PR and we can take it from there in review.
It may be good to verify it first by some local implementation on one of the docs websites, to see if that works as intended in the context of the...
@petesfrench What's the status of this? You had some PR for that on one of docs websites, but I don't know where it was and has it landed?