Bart Koelman

Fix S4456/S4457 FN: Recognize ArgumentNullException.ThrowIfNull()

1

### Description The next analyzers do not recognize the usage of `ArgumentNullException.ThrowIfNull()`, which was [added in .NET 6](https://docs.microsoft.com/en-us/dotnet/api/system.argumentnullexception.throwifnull?view=net-6.0). - [S4456](https://sonarsource.github.io/rspec/#/rspec/S4456/csharp): Parameter validation in yielding methods should be wrapped - [S4457](https://sonarsource.github.io/rspec/#/rspec/S4457/csharp):...

Fix S3900 FP: Recognize ArgumentNullException.ThrowIfNull()

5

### Description S3900 (Arguments of public methods should be validated against null) does not recognize the usage of `ArgumentNullException.ThrowIfNull()`, which was [added in .NET 6](https://docs.microsoft.com/en-us/dotnet/api/system.argumentnullexception.throwifnull?view=net-6.0). ### Repro steps ```c# public...

Use FluentAssertions instead of Xunit assertions

2

Refactor existing tests to use [FluentAssertions](https://fluentassertions.com/) instead of `Assert.*` methods, to get better feedback than "True should be False" when a test fails. This can be automated using https://github.com/fluentassertions/fluentassertions.analyzers, which...

This enables to detect packaging issues early in pull requests, without increasing build times during debug. - Because the default for `IsPackable` varies per SDK, we should: - Explicitly set...

Address existing violations of [SA1401: Fields should be private](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1401.md) in the codebase and set severity to `Warning` in `Steeltoe.Debug.ruleset` and `Steeltoe.Release.ruleset`. To find existing violations, enable the rule (see above)...

This issue tracks annotating the codebase for [nullable reference types](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/nullable-reference-types). General guidance: - Compile/test against .NET 7 or higher (only the core libraries are annotated in .NET 6, and several...

Review [SonarCube Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=SteeltoeOSS_steeltoe) These rules are unavailable in the IDE. Existing violations can be found at the link above. To address the violations, choose from the following on a...

Address existing violations of [S6354: Use a testable date/time provider](https://rules.sonarsource.com/csharp/RSPEC-6354) in the codebase and set severity to `Warning` in `Steeltoe.Debug.ruleset` and `Steeltoe.Release.ruleset`. To find existing violations, enable the rule (see...

Address existing violations of [S4487: Unread "private" fields should be removed](https://rules.sonarsource.com/csharp/RSPEC-4487) in the codebase and set severity to `Info` in `Steeltoe.Debug.ruleset` and to `Warning` in `Steeltoe.Release.ruleset`. Note: The difference in...