action-scheduler
action-scheduler copied to clipboard
Try: Make code coverage work
I had to make a few changes to let us use a relatively current and, most importantly, stock phpunit. Other changes I implemented to enable the process suggested by Codecov.
The one change that seems to break about 25 assertions is using the @before and @after annotations instead of magic method names -- but my suspicion is that this is because those method now actually work. Previously we called parent::setUp even though the parent class was providing a set_up method ... and one missing the @before annotation at that.
So the next step here is to see whether the failing assertions actually make sense (as in, whether our expectations are actually correct) or else what is causing the results to be different from what we expect. Maybe the annotated set_up and tear_down methods aren't running properly at all.
Pinging @barryhughes for awareness -- my suspicion right now is that not all set_up and tear_down methods are running as intended and possibly might never have. I need to focus back on other things for the time being so this PR here is a sort of save point.
Good find!