Pavel Bar

Results 11 comments of Pavel Bar

@aesteve-rh Code written very nice & clean :):):)

Regarding new `VolumeGroupDisableOptionError` error. I never had to add a new VDSM error, but looking at `CannotCreateLogicalVolume` as an example I see it's declared in `org.ovirt.engine.ui.frontend.VdsmErrors` class, `VdsmErrors.properties` and in...

> If User send REST API request for ovirt-engine/api/disks/{diskid}/disksnapshots?include_active&include_template he will get this incorrect href back . Now it will get correct output that will look like this . >...

BTW, added a Jira ticket: https://issues.redhat.com/browse/RHV-47841

> @barpavel any updates on the issue? Currently there is no progress with this and other similar pending issues. Until 4.5.0 release we do not have capacity for it :(...

> @barpavel Anything else missing? If not, then please move the PR to review ... Yes, there were few more things I wanted to add, the PR is not finished....

> I'd still handle the `checkpointId == null` branch, just to log (or maybe even an audit log) for debugging I think audit log is preferred, and then keep the...

> > A better solution could be to add some flag like "ignore incremental backup failure" / "ignore missing checkpoint" that will allow user to decide if he/she wants to...

> > > > A better solution could be to add some flag like "ignore incremental backup failure" / "ignore missing checkpoint" that will allow user to decide if he/she...

Actually one of the reasons this PR started, was that I saw the following strange documentation, see https://docs.ansible.com/ansible/latest/collections/ovirt/ovirt/ovirt_disk_module.html ``` bootable boolean True if the disk should be bootable. By default...