Chet Husk

Results 587 comments of Chet Husk

We don't currently get any scope information from FCS for the literals or suffixes in the values, so if you wanted to fix this it would require a change to...

I did a super-basic syntax walker + constant-value scope, and initial results are promising: ![image](https://user-images.githubusercontent.com/573979/134732257-af67816f-3812-463d-962b-1be57dcc99f6.png) What you're seeing here is that the whole constant value, numeric and format string, is...

Right now this is implemented in FSAC, but this kind of AST walker, unlike the position-directed traversal that's already there, would be a prime candidate for pushing into FCS.

The upshot of this syntax-level colorization is we may not need as much/anything in the textmate grammars. Especially if we split up tokens from parsing (which is fast) and checking...

The root cause has been diagnosed and fixed in the ionide/proj-info repo ,now it's a matter of flowing that into FSAC and updating this repo.

hopefully a week or so? the FSAC pipelines have been giving me a bit of trouble though.

@inouiw that's exactly what's taking my time :) the plan is to test FSAC against pipelines for the global.json in the repo, the latest 6.x SDK, and the latest 7.x...

There's a version of FSAC released that fixes this, but it introduced a failure mode that we need to fix before we include that version in Ionide.

Thanks @dsyme - been blocked on https://github.com/fsharp/FsAutoComplete/issues/1009 lately, that's the only real blocker to releasing a new Ionide. For some reason our emacs clients (and possibly others?) are reporting crashes...

We're mostly prepped for a release - those changes are in https://github.com/ionide/ionide-vscode-fsharp/pull/1782. Waiting for some community feedback from our emacs users to see about a proposed fix for crashes in...