Jindřich Bär

Results 108 comments of Jindřich Bär

Thank you @harm-matthias-harms for bringing this up. Indeed, there is an issue with the way we're handling the sessions in the browser crawlers. This is because a running browser instance...

Apologies for a ping on such an ancient ticket - I just want to mention we still keep track of this issue. Making this part of Crawlee right is one...

Please merge the latest `master` into your branch so we only get your changes in the diff. Cheers!

> > Thank you for your initiative! > > There are some things I'm not too sure about (see my comments). Also, I see that your branch is almost a...

So if I understand this correctly, we cannot get rid of `got-scraping` just yet because of the breaking change in `BasicCrawlingContext.sendRequest`, right? Does it mean we _have to_ model the...

Also, a completely unrelated thought / nit, but what file and directory casing convention are we following in Crawlee? It's already messy in the current codebase, but seeing `snake_case` files...

Alright, I just went through it; it seems like reasonable stuff to me 👍🏽 I dislike the idea of `responseType` on `Request` from `got`, but the generic typing looks good,...

> new tests shouldn't be necessary Sure, I'd just like to see the "minimal HTTP client example", but you're probably right; we don't need to add more tests because of...

Just to make things clear - there are two different initiatives regarding the "stealth" scraping: - **`fingerprint-suite`** ([github](https://github.com/apify/fingerprint-suite)): a bunch of libraries for generating real-life HTTP header sets (making sure...

The new changes are reusing the `CodeBlock` from the Docusaurus theme that has the code highlight working. The design is slightly different. |before|after| |---|---| |![obrazek](https://github.com/user-attachments/assets/7c551f36-6b84-42f6-8be5-5725c5a6553a)|![obrazek](https://github.com/user-attachments/assets/ce04efff-d2f7-4237-929d-03ec8f20547a)| The reason for the broken...