Geert Barentsen

Results 166 comments of Geert Barentsen

We recently refactored `SFFCorrector` (#613). I checked this example and find that it still fails, though the error message has changed! ## Input ```python import lightkurve as lk tpf =...

The issue here is as follow: * `aperture_mask="threshold"` returns a mask containing just one pixel; * in turn, this causes the centroid values to be constant; * in turn, this...

I confirmed this bug still exists in the current master branch (i.e. Lightkurve v2.0b4).

Oops! Looks like we can safely remove line 178!

@stephtdouglas Nobody has started working on this yet, and it would be really cool to add this to Lightkurve. I would be delighted to review and merge a PR if...

@stephtdouglas Yep! When you open a PR, the tests will run and you will see the results online. You're welcome to use that mechanism before completing work on a branch....

@stephtdouglas Thank you for looking into this!! There is no doubt that we should add `time_column` and `error_column` arguments to the `read_generic_lightcurve` function. **However**: if this change has complicated repercussions...

@stephtdouglas Good news: I went ahead and added `time_column` and `flux_err_column` arguments to `read_generic_lightcurve()`. (Make sure to branch off the latest version of `master` if you decide to work on...

Over in #707 I have updated `requirements.txt` to exclude SciPy v1.4.0 and v1.4.1 for now. Fingers crossed the issue will be fixed in v1.4.2...

@texadactyl Thanks for reminding me of this issue!! :+1: v1.5.0rc1 appears to be available on pypi: ```bash $ pip install scipy==1.5.0rc1 ``` Using this version, I find that `values` is...