barbetb

Results 13 comments of barbetb

So I have this retry interceptor: ``` @Slf4j @RequiredArgsConstructor public class RetryOnFailureInterceptor implements Interceptor { private final int maxRetryCount; @Override public Response intercept(final Chain chain) throws IOException { final Request...

Hi, what in the code do you see is not thread safe? It's a interceptor on the client and there is no input in it other than the number of...

@yschimke no worries, thanks for taking time to review this. Would be nice if we found a solution.

Yes we are definitely a step further now, but not all problems solved. I made the test a bit simpler, I removed my custom builder, so you can use my...

Unfortunatly something else I discovered: if I add ``` .connectTimeout(1000, TimeUnit.MILLISECONDS) .callTimeout(300, TimeUnit.MILLISECONDS) ``` to the client, the test fails again, also for the `.setSocketPolicy(SocketPolicy.NO_RESPONSE);` scenario: ``` 21:07:08.481 [main] INFO...

Yes, it reports 'waiting for queues to shut down'. So my initial interpretation is that there is a timeout on the queue of mockwebserver responses, and if one takes too...

I'll have to wait for a release with the fix, as I cannot use unreleased packages in my project. I'll just have to disable this test. If anyone wants the...

Sorry I don't understand how your sleepIfDelayed method works with my test. Where do I call it? And is this the java equivalent correctly? ``` @SneakyThrows private void sleepIfDelayed(final Socket...

I've implemented the 2.x.x library, is there some documentation how to migrate to the 3.x.x library? I tried to compile with the 3.x.x and then see if I could fix...

Any update on this? 0.16.0 if libthrift is out, when can we expect and update?