Sean Barbeau

Results 1029 comments of Sean Barbeau

Also - I'm going to close and re-open this PR so our new ICLA bot can (hopefully) comment. @kevinsafon please sign the ICLA linked there.

Ok, @kevinsafon ICLA looks good, thanks!

@m-yang Now that https://github.com/OneBusAway/onebusaway-android/pull/867 is merged, could you please rebase this branch on the current master branch and force-push to same remote branch to replace the current PR contents? It...

@m-yang Regarding the failing CLA check - could you please see https://github.com/cla-assistant/cla-assistant/issues/186, and try following the steps outlined there to see if that fixes it?

Thanks for taking a shot at this! Nice CLA is fixed too. The left margin will need to be set based on screen width which varies per device. For example,...

>The fix required that HomeActivity implement a callback to listen for the the onMapReady call in the BaseMapFragment since the checkLeftHandMode in HomeActivity executed before the map was ready, leading...

@m-yang Sorry for the delay getting back to you, I've been swamped lately and got buried in some other tasks. Hopefully I'll have a chance to look at this soon.

@m-yang `mLastSavedInstanceState` will be null if there isn't a previously saved map state (this is a feature of the Android framework). In that case, you would need to instantiate a...

Newest iOS UI for this feature is at https://github.com/OneBusAway/OBAKit/pull/254#issuecomment-661960035 ![image](https://user-images.githubusercontent.com/928045/88096325-764ac080-cb64-11ea-9af1-df65eb7476e4.png)

Yeah, Travis always seems to pass too. I've noticed that Travis does a `mvn install -DskipTests=true` following by a `mvn test -B` (which always seems to pass), so it might...