onebusaway-application-modules icon indicating copy to clipboard operation
onebusaway-application-modules copied to clipboard

Published 20 hours ago • verified publisher icon OneBusAway

Fix for #185

Open kevinsafon opened this issue 9 years ago • 5 comments

Return -1 instead of throwing an exception so that it doesnt stop the whole process and just ignore this stop update

kevinsafon avatar Oct 18 '16 01:10 kevinsafon

Can one of the admins verify this patch?

onebusawaybot avatar Oct 18 '16 01:10 onebusawaybot

Thanks for submitting this @kevinsafon!

barbeau avatar Nov 02 '16 19:11 barbeau

Also - I'm going to close and re-open this PR so our new ICLA bot can (hopefully) comment. @kevinsafon please sign the ICLA linked there.

barbeau avatar Nov 02 '16 19:11 barbeau

Ok, @kevinsafon ICLA looks good, thanks!

barbeau avatar Nov 02 '16 19:11 barbeau

Ok, sounds good @barbeau.

I added the comment and logging in the 2 methods: computeDepartureTime and computeArrivalTime

kevinsafon avatar Nov 03 '16 02:11 kevinsafon

no action in 8 years. closing.

aaronbrethorst avatar Apr 08 '24 05:04 aaronbrethorst