Barak Katzir

Ah, sorry. I forgot to check main before opening the issue. It does look as though this is solved in main. An `@overload` can be really nice here actually. If...

Both mypy and pyright can be configured to emit an error if there is an unusued `# type: ignore`. For mypy `--warn-unused-ignores` or `warn_unused_ignores`. For pyright `reportUnnecessaryTypeIgnoreComment`.

That's very surprising, @IvanIsCoding. How did you run pyright? When I use `rustworkx` v0.16 with all the type-annotations improvements ️(♥️), `pyright` seems to be happy even in strict mode. In...

Wow! That is a very long list. I don't remember it being that long. I'll have a look at it after a good night's sleep.

Okay, so `pyright` indeed has an... opinionated default for whether to recurse through dependencies in `--verifytypes`, but this can be turned off with `--ignoreexternal`. If I do so I find...

Note that if you want to add both `mypy` and `pyright` to do type checking they can clash in their pragma comment syntax. If you do plan to add both...

It wasn't clear to me at first that the number in the CHANGES.rst reference the relevant issues (🤦🏼‍♂️). Fixed now.

I chose to switch the overload signature handling from using `sphinx.util.inspect.signature_from_ast` function to use the usual Documenter one (via `sphinx.util.inspect.signature` which uses `typing.get_type_hints`). If you think that it's better to...

@AA-Turner, did you get a chance to look at my PR? If not, I can wait. If it is not on par with the code standards I'm willing to fix...

Interesting, now that you write it like that it seems that `mypy` and `pyright` did exactly that, and forbade adding `None` to `int` in the reproduction I gave. If so,...