Aubertin Baptiste

Hi @molbap @zucchini-nlp ! Thanks for the detailed review and the instructions! Sorry I didn't get back to you last week, I was a little overloaded with the release. i...

Hi I think all the tests passed and i rebased the branch :). Please tell me if I need to do something else Thanks a lot for your help !

> There's a couple errors on the `slow tests` I just ran: with > > ```python > FAILED tests/models/lightonocr/test_modeling_lightonocr.py::LightOnOCRForConditionalGenerationIntegrationTest::test_model_can_generate_without_images - AttributeError: 'LightOnOCRConfig' object has no attribute 'vocab_size' > FAILED tests/models/lightonocr/test_modeling_lightonocr.py::LightOnOCRForConditionalGenerationIntegrationTest::test_model_forward_with_images...

Hi @molbap thanks again for your help ! Could you please re trigger the slow tests to be sure that everything pass before the intervention of the last reviewer :)...

> Hye @baptiste-aubertin , While we're waiting on core maintainer's review, I left a few comments and questions below, mostly about things that looks redundant to me. LMK what you...

> hey hey, there's just this > > ```shell > Traceback (most recent call last): > File "/home/runner/work/transformers/transformers/.venv/bin/doc-builder", line 10, in > sys.exit(main()) > File "/home/runner/work/transformers/transformers/.venv/lib/python3.10/site-packages/doc_builder/commands/doc_builder_cli.py", line 50, in main...

Hi I rebased and adapted the tied weight to the new format :) I also removed `_init_weights` methods who triggered test fail and seemed to be useless

A test is not passing but it not seems to be related with our model. Could you please run the slow tests @molbap ?

hi @molbap , i fixed the tests. Can you rerun the slow one, the device test needs to be run on several gpus :)

I re rabased and I still have tests not related to our model who are failing :/